[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 09/18] target/s390x: Return exception from mmu_translate
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v4 09/18] target/s390x: Return exception from mmu_translate |
|
Date: |
Tue, 1 Oct 2019 09:21:15 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 10/1/19 8:30 AM, David Hildenbrand wrote:
> TEST check-qtest-s390x: tests/test-hmp
> Broken pipe
> tests/libqtest.c:149: kill_qemu() detected QEMU death from signal 11
> (Segmentation fault) (core dumped)
Missed a change to s390_cpu_get_phys_page_debug:
(gdb) bt 4
#0 0x00005555557a4923 in mmu_translate (env=0x555555f7c330,
vaddr=vaddr@entry=0, rw=rw@entry=0, asc=0, raddr=raddr@entry=0x7fffffffd010,
flags=flags@entry=0x7fffffffd00c, tec=0x0) at
/home/rth/qemu/qemu/target/s390x/mmu_helper.c:376
#1 0x000055555575a135 in s390_cpu_get_phys_page_debug (cs=<optimized out>,
vaddr=0) at /home/rth/qemu/qemu/target/s390x/helper.c:70
#2 0x0000555555752219 in cpu_get_phys_page_attrs_debug (attrs=0x7fffffffd034,
addr=0, cpu=<optimized out>) at /home/rth/qemu/qemu/include/hw/core/cpu.h:605
#3 0x0000555555752219 in hmp_gva2gpa (mon=0x555555f53310, qdict=<optimized
out>) at /home/rth/qemu/qemu/monitor/misc.c:850
Irritating that the "0" produced an implicit null instead of a compile-time
failure. Anyway, will fix and rebase on your mmu branch.
r~