Re: [PATCH v2 3/4] s390x: sclp: fix error handling for oversize control blocks

[David Hildenbrand]

On 27.09.19 15:33, Claudio Imbrenda wrote:
> From: Janosch Frank <address@hidden>
> 
> Requests over 4k are not a spec exception.
> 
> Signed-off-by: Janosch Frank <address@hidden>
> Reviewed-by: Jason J. Herne <address@hidden>
> ---
>  hw/s390x/sclp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index 73244c9..abb6e50 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -213,8 +213,7 @@ int sclp_service_call(CPUS390XState *env, uint64_t sccb, 
> uint32_t code)
>      cpu_physical_memory_read(sccb, &work_sccb, sccb_len);
>  
>      /* Valid sccb sizes */
> -    if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader) ||
> -        be16_to_cpu(work_sccb.h.length) > SCCB_SIZE) {
> +    if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader)) {
>          r = -PGM_SPECIFICATION;
>          goto out;
>      }
> 

Acked-by: David Hildenbrand <address@hidden>

-- 

Thanks,

David / dhildenb