Re: [PATCH v3 00/33] testing/next (docker,tcg, alpha ;-)

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/33] testing/next (docker,tcg, alpha ;-)

From:	no-reply
Subject:	Re: [PATCH v3 00/33] testing/next (docker,tcg, alpha ;-)
Date:	Fri, 27 Sep 2019 05:08:14 -0700 (PDT)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH  v3 00/33] testing/next (docker,tcg, alpha ;-)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   eb13d1c..1329132  master     -> master
Switched to a new branch 'test'
ffd20f4 tests/docker: remove debian-powerpc-user-cross
dd21fe2 docker: move tests from python2 to python3
8832bde docker: remove unused debian-sid
65f1c97 docker: remove unused debian-ports
a29b1cb docker: remove 'deprecated' image definitions
a931368 docker: removed unused debian8 partial image
f4567b8 docker: remove debian8-mxe definitions
93e89f9 .shippable.yml: Build WHPX enabled binaries
3a7114e tests/docker: Add fedora-win10sdk-cross image
3cbd4bd target/i386: Fix broken build with WHPX enabled
50fe6b1 docs/devel: add "check-tcg" to testing.rst
8d1c8ff configure: preserve PKG_CONFIG for subdir builds
c7edc91 tests/tcg: add simple record/replay smoke test for aarch64
eaabc4c tests/tcg: add generic version of float_convs
96edbb3 tests/tcg: add float_madds test to multiarch
31b4483 tests/tcg: re-enable linux-test for ppc64abi32
24b4f78 tests/tcg: clean-up some comments after the de-tangling
2f94f4f podman: fix command invocation
9156370 tests/docker: reduce scary warnings by cleaning up clean up
cc39cf0 tests/docker: remove python2.7 from debian9-mxe
35a93b6 tests/docker: fix DOCKER_PARTIAL_IMAGES
d615580 tests/docker: add sanitizers back to clang build
61edf90 target/ppc: fix signal delivery for ppc64abi32
a727416 target/alpha: Tidy helper_fp_exc_raise_s
e608462 target/alpha: Mask IOV exception with INV for user-only
2fbbbf9 target/alpha: Write to fpcr_flush_to_zero once
fe559b4 target/alpha: Handle SWCR_MAP_DMZ earlier
7ca9641 target/alpha: Fix SWCR_TRAP_ENABLE_MASK
75a7ea1 target/alpha: Fix SWCR_MAP_UMZ
7787f7f target/alpha: Use array for FPCR_DYN conversion

=== OUTPUT BEGIN ===
1/30 Checking commit 7787f7f50982 (target/alpha: Use array for FPCR_DYN 
conversion)
2/30 Checking commit 75a7ea10edd6 (target/alpha: Fix SWCR_MAP_UMZ)
3/30 Checking commit 7ca9641a6e61 (target/alpha: Fix SWCR_TRAP_ENABLE_MASK)
4/30 Checking commit fe559b417fd9 (target/alpha: Handle SWCR_MAP_DMZ earlier)
5/30 Checking commit 2fbbbf9f736d (target/alpha: Write to fpcr_flush_to_zero 
once)
6/30 Checking commit e608462627f9 (target/alpha: Mask IOV exception with INV 
for user-only)
7/30 Checking commit a727416b2c78 (target/alpha: Tidy helper_fp_exc_raise_s)
8/30 Checking commit 61edf90d2b0f (target/ppc: fix signal delivery for 
ppc64abi32)
9/30 Checking commit d61558009a77 (tests/docker: add sanitizers back to clang 
build)
10/30 Checking commit 35a93b64aa3d (tests/docker: fix DOCKER_PARTIAL_IMAGES)
11/30 Checking commit cc39cf0b7462 (tests/docker: remove python2.7 from 
debian9-mxe)
12/30 Checking commit 9156370e10dc (tests/docker: reduce scary warnings by 
cleaning up clean up)
13/30 Checking commit 2f94f4f87cd4 (podman: fix command invocation)
14/30 Checking commit 24b4f78e27c3 (tests/tcg: clean-up some comments after the 
de-tangling)
15/30 Checking commit 31b4483f1703 (tests/tcg: re-enable linux-test for 
ppc64abi32)
16/30 Checking commit 96edbb368f39 (tests/tcg: add float_madds test to 
multiarch)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

WARNING: architecture specific defines should be avoided
#1717: FILE: tests/tcg/multiarch/float_helpers.c:82:
+# if __GNUC_PREREQ(3, 3)

ERROR: space prohibited between function name and open parenthesis '('
#1718: FILE: tests/tcg/multiarch/float_helpers.c:83:
+#  define SNANF (__builtin_nansf (""))

ERROR: space prohibited between function name and open parenthesis '('
#1719: FILE: tests/tcg/multiarch/float_helpers.c:84:
+#  define SNAN (__builtin_nans (""))

ERROR: space prohibited between function name and open parenthesis '('
#1720: FILE: tests/tcg/multiarch/float_helpers.c:85:
+#  define SNANL (__builtin_nansl (""))

ERROR: spaces required around that '+' (ctx:VxV)
#1729: FILE: tests/tcg/multiarch/float_helpers.c:94:
+    -0x1.1874b2p+103,
                 ^

ERROR: spaces required around that '+' (ctx:VxV)
#1730: FILE: tests/tcg/multiarch/float_helpers.c:95:
+    -0x1.c0bab6p+99,
                 ^

ERROR: spaces required around that '-' (ctx:VxV)
#1731: FILE: tests/tcg/multiarch/float_helpers.c:96:
+    -0x1.31f75p-40,
                ^

ERROR: spaces required around that '-' (ctx:VxV)
#1732: FILE: tests/tcg/multiarch/float_helpers.c:97:
+    -0x1.505444p-66,
                 ^

ERROR: spaces required around that '-' (ctx:VxV)
#1736: FILE: tests/tcg/multiarch/float_helpers.c:101:
+    0x1p-25,
         ^

ERROR: spaces required around that '-' (ctx:VxV)
#1737: FILE: tests/tcg/multiarch/float_helpers.c:102:
+    0x1.ffffe6p-25, /* min positive FP16 subnormal */
                ^

ERROR: spaces required around that '-' (ctx:VxV)
#1738: FILE: tests/tcg/multiarch/float_helpers.c:103:
+    0x1.ff801ap-15, /* max subnormal FP16 */
                ^

ERROR: spaces required around that '-' (ctx:VxV)
#1739: FILE: tests/tcg/multiarch/float_helpers.c:104:
+    0x1.00000cp-14, /* min positive normal FP16 */
                ^

ERROR: spaces required around that '+' (ctx:VxV)
#1741: FILE: tests/tcg/multiarch/float_helpers.c:106:
+    0x1.004p+0, /* smallest float after 1.0 FP16 */
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#1744: FILE: tests/tcg/multiarch/float_helpers.c:109:
+    0x1.ffbep+15,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#1745: FILE: tests/tcg/multiarch/float_helpers.c:110:
+    0x1.ffcp+15, /* max FP16 */
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#1746: FILE: tests/tcg/multiarch/float_helpers.c:111:
+    0x1.ffc2p+15,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#1747: FILE: tests/tcg/multiarch/float_helpers.c:112:
+    0x1.ffbfp+16,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#1748: FILE: tests/tcg/multiarch/float_helpers.c:113:
+    0x1.ffcp+16, /* max AFP */
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#1749: FILE: tests/tcg/multiarch/float_helpers.c:114:
+    0x1.ffc1p+16,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#1750: FILE: tests/tcg/multiarch/float_helpers.c:115:
+    0x1.c0bab6p+99,
                ^

ERROR: spaces required around that '-' (ctx:VxV)
#1789: FILE: tests/tcg/multiarch/float_helpers.c:154:
+    {-FLT_MAX-1.0},
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#1791: FILE: tests/tcg/multiarch/float_helpers.c:156:
+    {-1.111E+31},
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#1792: FILE: tests/tcg/multiarch/float_helpers.c:157:
+    {-1.111E+30}, /* half prec */
             ^

ERROR: spaces required around that '-' (ctx:VxV)
#1798: FILE: tests/tcg/multiarch/float_helpers.c:163:
+    {2.98023224e-08},
                 ^

ERROR: spaces required around that '-' (ctx:VxV)
#1799: FILE: tests/tcg/multiarch/float_helpers.c:164:
+    {5.96046E-8}, /* min positive FP16 subnormal */
              ^

ERROR: spaces required around that '-' (ctx:VxV)
#1800: FILE: tests/tcg/multiarch/float_helpers.c:165:
+    {6.09756E-5}, /* max subnormal FP16 */
              ^

ERROR: spaces required around that '-' (ctx:VxV)
#1801: FILE: tests/tcg/multiarch/float_helpers.c:166:
+    {6.10352E-5}, /* min positive normal FP16 */
              ^

ERROR: spaces required around that '-' (ctx:VxV)
#1805: FILE: tests/tcg/multiarch/float_helpers.c:170:
+    {1.3789972848607228e-308},
                         ^

ERROR: spaces required around that '-' (ctx:VxV)
#1806: FILE: tests/tcg/multiarch/float_helpers.c:171:
+    {1.4914738736681624e-308},
                         ^

ERROR: "foo * bar" should be "foo *bar"
#1893: FILE: tests/tcg/multiarch/float_helpers.h:22:
+char * fmt_f16(uint16_t);

ERROR: "foo * bar" should be "foo *bar"
#1894: FILE: tests/tcg/multiarch/float_helpers.h:23:
+char * fmt_f32(float);

ERROR: "foo * bar" should be "foo *bar"
#1895: FILE: tests/tcg/multiarch/float_helpers.h:24:
+char * fmt_f64(double);

ERROR: "foo * bar" should be "foo *bar"
#1897: FILE: tests/tcg/multiarch/float_helpers.h:26:
+char * fmt_flags(void);

ERROR: spaces required around that '%' (ctx:VxV)
#1992: FILE: tests/tcg/multiarch/float_madds.c:89:
+                a = get_f32(j + ((k)%3));
                                     ^

ERROR: spaces required around that '+' (ctx:VxV)
#1993: FILE: tests/tcg/multiarch/float_madds.c:90:
+                b = get_f32(j + ((k+1)%3));
                                    ^

ERROR: spaces required around that '%' (ctx:VxV)
#1993: FILE: tests/tcg/multiarch/float_madds.c:90:
+                b = get_f32(j + ((k+1)%3));
                                       ^

ERROR: spaces required around that '+' (ctx:VxV)
#1994: FILE: tests/tcg/multiarch/float_madds.c:91:
+                c = get_f32(j + ((k+2)%3));
                                    ^

ERROR: spaces required around that '%' (ctx:VxV)
#1994: FILE: tests/tcg/multiarch/float_madds.c:91:
+                c = get_f32(j + ((k+2)%3));
                                       ^

ERROR: line over 90 characters
#2001: FILE: tests/tcg/multiarch/float_madds.c:98:
+        do_madds(0x1.ffffffffffffcp-1022, 0x1.0000000000001p-1, 
0x0.0000000000001p-1022, j, 0);

ERROR: spaces required around that '-' (ctx:VxV)
#2001: FILE: tests/tcg/multiarch/float_madds.c:98:
+        do_madds(0x1.ffffffffffffcp-1022, 0x1.0000000000001p-1, 
0x0.0000000000001p-1022, j, 0);
                                    ^

ERROR: spaces required around that '-' (ctx:VxV)
#2001: FILE: tests/tcg/multiarch/float_madds.c:98:
+        do_madds(0x1.ffffffffffffcp-1022, 0x1.0000000000001p-1, 
0x0.0000000000001p-1022, j, 0);
                                                             ^

ERROR: spaces required around that '-' (ctx:VxV)
#2001: FILE: tests/tcg/multiarch/float_madds.c:98:
+        do_madds(0x1.ffffffffffffcp-1022, 0x1.0000000000001p-1, 
0x0.0000000000001p-1022, j, 0);
                                                                                
   ^

ERROR: spaces required around that '-' (ctx:VxV)
#2002: FILE: tests/tcg/multiarch/float_madds.c:99:
+        do_madds(0x8p-152, 0x8p-152, 0x8p-152, j+1, 0);
                      ^

ERROR: spaces required around that '-' (ctx:VxV)
#2002: FILE: tests/tcg/multiarch/float_madds.c:99:
+        do_madds(0x8p-152, 0x8p-152, 0x8p-152, j+1, 0);
                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#2002: FILE: tests/tcg/multiarch/float_madds.c:99:
+        do_madds(0x8p-152, 0x8p-152, 0x8p-152, j+1, 0);
                                          ^

ERROR: spaces required around that '+' (ctx:VxV)
#2002: FILE: tests/tcg/multiarch/float_madds.c:99:
+        do_madds(0x8p-152, 0x8p-152, 0x8p-152, j+1, 0);
                                                 ^

total: 45 errors, 2 warnings, 1942 lines checked

Patch 16/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/30 Checking commit eaabc4c89da0 (tests/tcg: add generic version of 
float_convs)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100755

ERROR: space prohibited after that open parenthesis '('
#1623: FILE: tests/tcg/multiarch/float_convs.c:75:
+CONVERT_SINGLE_TO_INT( int32, PRId32)

ERROR: space prohibited after that open parenthesis '('
#1625: FILE: tests/tcg/multiarch/float_convs.c:77:
+CONVERT_SINGLE_TO_INT( int64, PRId64)

total: 2 errors, 1 warnings, 1615 lines checked

Patch 17/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/30 Checking commit c7edc9100775 (tests/tcg: add simple record/replay smoke 
test for aarch64)
19/30 Checking commit 8d1c8ffdd644 (configure: preserve PKG_CONFIG for subdir 
builds)
20/30 Checking commit 50fe6b16d005 (docs/devel: add "check-tcg" to testing.rst)
21/30 Checking commit 3cbd4bdff449 (target/i386: Fix broken build with WHPX 
enabled)
22/30 Checking commit 3a7114ee93f0 (tests/docker: Add fedora-win10sdk-cross 
image)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

ERROR: line over 90 characters
#85: FILE: tests/docker/dockerfiles/win10sdk-dl.sh:12:
+BASE_URL=$(curl --silent --include 
'http://go.microsoft.com/fwlink/?prd=11966&pver=1.0&plcid=0x409&clcid=0x409&ar=Windows10&sar=SDK&o1=10.0.18362.1'
 | sed -nE 's_Location: (.*)/\r_\1_p')/Installers

ERROR: line over 90 characters
#90: FILE: tests/docker/dockerfiles/win10sdk-dl.sh:17:
+    CAB_NAME=$(msiextract Windows\ SDK\ Desktop\ Headers\ x86-x86_en-us.msi 
3>&1 2>&3 3>&-| sed -nE "s_.*Error opening file $PWD/(.*): No such file or 
directory_\1_p")

WARNING: line over 80 characters
#97: FILE: tests/docker/dockerfiles/win10sdk-dl.sh:24:
+for inc in "${WINDIR}/Program Files/Windows 
Kits/10/Include/10.0.18362.0/um"/WinHv*; do

total: 2 errors, 2 warnings, 58 lines checked

Patch 22/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

23/30 Checking commit 93e89f9186ea (.shippable.yml: Build WHPX enabled binaries)
24/30 Checking commit f4567b8509c0 (docker: remove debian8-mxe definitions)
25/30 Checking commit a93136873e17 (docker: removed unused debian8 partial 
image)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
deleted file mode 100644

total: 0 errors, 1 warnings, 8 lines checked

Patch 25/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/30 Checking commit a29b1cbf09e6 (docker: remove 'deprecated' image 
definitions)
27/30 Checking commit 65f1c97bd7ae (docker: remove unused debian-ports)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
deleted file mode 100644

total: 0 errors, 1 warnings, 8 lines checked

Patch 27/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/30 Checking commit 8832bdecc0b3 (docker: remove unused debian-sid)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
deleted file mode 100644

total: 0 errors, 1 warnings, 8 lines checked

Patch 28/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/30 Checking commit dd21fe252164 (docker: move tests from python2 to python3)
30/30 Checking commit ffd20f48053b (tests/docker: remove 
debian-powerpc-user-cross)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
deleted file mode 100644

total: 0 errors, 1 warnings, 15 lines checked

Patch 30/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 16/33] podman: fix command invocation, (continued)
- [PATCH v3 19/33] tests/tcg: add float_madds test to multiarch, Alex Bennée, 2019/09/24
  - Re: [PATCH v3 19/33] tests/tcg: add float_madds test to multiarch, Philippe Mathieu-Daudé, 2019/09/25
- [PATCH v3 33/33] tests/docker: remove debian-powerpc-user-cross, Alex Bennée, 2019/09/24
  - Re: [PATCH v3 33/33] tests/docker: remove debian-powerpc-user-cross, Richard Henderson, 2019/09/25
  - Re: [PATCH v3 33/33] tests/docker: remove debian-powerpc-user-cross, Philippe Mathieu-Daudé, 2019/09/25
- [PATCH v3 20/33] tests/tcg: add generic version of float_convs, Alex Bennée, 2019/09/24
  - Re: [PATCH v3 20/33] tests/tcg: add generic version of float_convs, Philippe Mathieu-Daudé, 2019/09/25
- [PATCH v3 31/33] docker: remove unused debian-sid, Alex Bennée, 2019/09/24
  - Re: [PATCH v3 31/33] docker: remove unused debian-sid, Philippe Mathieu-Daudé, 2019/09/25
- Re: [PATCH v3 00/33] testing/next (docker,tcg, alpha ;-), no-reply <=

Prev by Date: Re: [Qemu-devel] [PATCH v4 03/10] iotests: add test-case to 165 to test reopening qcow2 bitmaps to RW
Next by Date: RE: [PATCH 0/2] RTC support for QEMU RISC-V virt machine
Previous by thread: Re: [PATCH v3 31/33] docker: remove unused debian-sid
Next by thread: [PATCH 0/1] dirty-bitmaps: remove deprecated autoload parameter
Index(es):
- Date
- Thread