[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] iotests: Fix 125
From: |
Max Reitz |
Subject: |
Re: [PATCH 0/3] iotests: Fix 125 |
Date: |
Fri, 27 Sep 2019 11:29:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 25.09.19 20:32, Max Reitz wrote:
> Hi,
>
> iotest 125 is very broken. It uses qemu-img info’s “disk size” to
> determine an image’s on-disk size, but it does so in a wrong way: It
> just fetches the first number ([0-9]+), but that isn’t very useful
> because qemu-img info emits human-readable values that include units and
> decimal points.
>
> We should ust stat -c %b instead. That’s done in patch 3.
> Unfortunately, doing so exposed more problems.
>
> Patch 1 fixes a stupid bug in the test itself that we never noticed
> because of what patch 3 fixes. (Pull patch 3 before patch 1 and you’ll
> see.)
>
> The other thing is actually a bug in XFS. Its fallocate()
> implementation rounds up the length independently of the offset, so if
> you try to fallocate an unaligned range, chances are that it might not
> allocate the last block your range touches. Patch 2 detects that case
> and skips the test then. (Pull patch 3 before patch 2 and you’ll see
> the test fail on XFS.)
>
>
> Max Reitz (3):
> iotests: Fix 125 for growth_mode = metadata
> iotests: Disable 125 on broken XFS versions
> iotests: Use stat -c %b in 125
>
> tests/qemu-iotests/125 | 45 +++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 42 insertions(+), 3 deletions(-)
Thanks for the review, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
And for the record, I’ve sent a patch to the XFS driver:
https://www.spinics.net/lists/linux-xfs/msg32174.html
Max
signature.asc
Description: OpenPGP digital signature