Re: [PATCH v3] qga: add command guest-get-devices for reporting VirtIO devices

[Tomáš Golembiovský]

already fixed in v4

On Thu, Sep 26, 2019 at 06:12:26PM -0700, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: address@hidden
> Subject: [PATCH v3] qga: add command guest-get-devices for reporting VirtIO 
> devices
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Switched to a new branch 'test'
> 42c2919 qga: add command guest-get-devices for reporting VirtIO devices
> 
> === OUTPUT BEGIN ===
> ERROR: "(foo*)" should be "(foo *)"
> #155: FILE: qga/commands-win32.c:2316:
> +    values = g_array_new(TRUE, TRUE, sizeof(gchar*));
> 
> ERROR: "foo* bar" should be "foo *bar"
> #157: FILE: qga/commands-win32.c:2318:
> +        gchar* id8 = g_utf16_to_utf8(id, -1, NULL, NULL, NULL);
> 
> total: 2 errors, 0 warnings, 281 lines checked
> 
> Commit 42c2919fb935 (qga: add command guest-get-devices for reporting VirtIO 
> devices) has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to address@hidden

-- 
Tomáš Golembiovský <address@hidden>