[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SeaBIOS] [PATCH v7 1/8] block: Refactor macros - fix tabbing
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [SeaBIOS] [PATCH v7 1/8] block: Refactor macros - fix tabbing |
Date: |
Thu, 26 Sep 2019 11:38:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 9/25/19 1:06 PM, Sam Eiderman wrote:
> From: Sam Eiderman <address@hidden>
>
> Fixing tabbing in block related macros.
>
> Reviewed-by: Karl Heubaum <address@hidden>
> Reviewed-by: Arbel Moshe <address@hidden>
> Signed-off-by: Sam Eiderman <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/ide/qdev.c | 2 +-
> include/hw/block/block.h | 16 ++++++++--------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
> index 6fba6b62b8..6dd219944f 100644
> --- a/hw/ide/qdev.c
> +++ b/hw/ide/qdev.c
> @@ -290,7 +290,7 @@ static void ide_drive_realize(IDEDevice *dev, Error
> **errp)
> DEFINE_BLOCK_PROPERTIES(IDEDrive, dev.conf), \
> DEFINE_BLOCK_ERROR_PROPERTIES(IDEDrive, dev.conf), \
> DEFINE_PROP_STRING("ver", IDEDrive, dev.version), \
> - DEFINE_PROP_UINT64("wwn", IDEDrive, dev.wwn, 0), \
> + DEFINE_PROP_UINT64("wwn", IDEDrive, dev.wwn, 0), \
> DEFINE_PROP_STRING("serial", IDEDrive, dev.serial),\
> DEFINE_PROP_STRING("model", IDEDrive, dev.model)
>
> diff --git a/include/hw/block/block.h b/include/hw/block/block.h
> index 607539057a..fd55a30bca 100644
> --- a/include/hw/block/block.h
> +++ b/include/hw/block/block.h
> @@ -50,21 +50,21 @@ static inline unsigned int
> get_physical_block_exp(BlockConf *conf)
> _conf.logical_block_size), \
> DEFINE_PROP_BLOCKSIZE("physical_block_size", _state, \
> _conf.physical_block_size), \
> - DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
> + DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
> DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0), \
> - DEFINE_PROP_UINT32("discard_granularity", _state, \
> - _conf.discard_granularity, -1), \
> - DEFINE_PROP_ON_OFF_AUTO("write-cache", _state, _conf.wce, \
> - ON_OFF_AUTO_AUTO), \
> + DEFINE_PROP_UINT32("discard_granularity", _state, \
> + _conf.discard_granularity, -1), \
> + DEFINE_PROP_ON_OFF_AUTO("write-cache", _state, _conf.wce, \
> + ON_OFF_AUTO_AUTO), \
> DEFINE_PROP_BOOL("share-rw", _state, _conf.share_rw, false)
>
> #define DEFINE_BLOCK_PROPERTIES(_state, _conf) \
> DEFINE_PROP_DRIVE("drive", _state, _conf.blk), \
> DEFINE_BLOCK_PROPERTIES_BASE(_state, _conf)
>
> -#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
> - DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
> - DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
> +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
> + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
> + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
> DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
>
> #define DEFINE_BLOCK_ERROR_PROPERTIES(_state, _conf) \
>
- [PATCH v7 0/8] Add Qemu to SeaBIOS LCHS interface, Sam Eiderman, 2019/09/25
- [PATCH v7 1/8] block: Refactor macros - fix tabbing, Sam Eiderman, 2019/09/25
- Re: [SeaBIOS] [PATCH v7 1/8] block: Refactor macros - fix tabbing,
Philippe Mathieu-Daudé <=
- [PATCH v7 2/8] block: Support providing LCHS from user, Sam Eiderman, 2019/09/25
- [PATCH v7 3/8] bootdevice: Add interface to gather LCHS, Sam Eiderman, 2019/09/25
- [PATCH v7 4/8] scsi: Propagate unrealize() callback to scsi-hd, Sam Eiderman, 2019/09/25
- [PATCH v7 5/8] bootdevice: Gather LCHS from all relevant devices, Sam Eiderman, 2019/09/25
- [PATCH v7 6/8] bootdevice: Refactor get_boot_devices_list, Sam Eiderman, 2019/09/25
- [PATCH v7 7/8] bootdevice: FW_CFG interface for LCHS values, Sam Eiderman, 2019/09/25