[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 30/33] docker: remove unused debian-ports
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 30/33] docker: remove unused debian-ports |
Date: |
Thu, 26 Sep 2019 00:23:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 9/24/19 11:01 PM, Alex Bennée wrote:
> From: John Snow <address@hidden>
>
> debian-ports is listed as a partial image, so we cannot run tests against it.
> Since it isn't used by any other testable image, remove it for now as it
> is prone to bitrot.
>
> Signed-off-by: John Snow <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/docker/Makefile.include | 2 +-
> tests/docker/dockerfiles/debian-ports.docker | 36 --------------------
> 2 files changed, 1 insertion(+), 37 deletions(-)
> delete mode 100644 tests/docker/dockerfiles/debian-ports.docker
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index fd6f470fbf8..053c418d8cd 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -6,7 +6,7 @@ DOCKER_SUFFIX := .docker
> DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
> # we don't run tests on intermediate images (used as base by another image)
> DOCKER_PARTIAL_IMAGES := debian9 debian10 debian-sid
> -DOCKER_PARTIAL_IMAGES += debian9-mxe debian-ports debian-bootstrap
> +DOCKER_PARTIAL_IMAGES += debian9-mxe debian-bootstrap
> DOCKER_IMAGES := $(sort $(notdir $(basename $(wildcard
> $(DOCKER_FILES_DIR)/*.docker))))
> DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
> # Use a global constant ccache directory to speed up repetitive builds
> diff --git a/tests/docker/dockerfiles/debian-ports.docker
> b/tests/docker/dockerfiles/debian-ports.docker
> deleted file mode 100644
> index 61bc3f2993a..00000000000
> --- a/tests/docker/dockerfiles/debian-ports.docker
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -#
> -# Docker multiarch cross-compiler target
> -#
> -# This docker target is builds on Debian Ports cross compiler targets
> -# to build distro with a selection of cross compilers for building test
> binaries.
> -#
> -# On its own you can't build much but the docker-foo-cross targets
> -# build on top of the base debian image.
> -#
> -FROM debian:unstable
> -
> -MAINTAINER Philippe Mathieu-Daudé <address@hidden>
> -
> -RUN echo "deb [arch=amd64] http://deb.debian.org/debian unstable main" >
> /etc/apt/sources.list
> -
> -# Duplicate deb line as deb-src
> -RUN cat /etc/apt/sources.list | sed -ne "s/^deb\ \(\[.*\]\
> \)\?\(.*\)/deb-src \2/p" >> /etc/apt/sources.list
> -
> -# Setup some basic tools we need
> -RUN apt-get update && \
> - DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
> - DEBIAN_FRONTEND=noninteractive eatmydata \
> - apt-get install -y --no-install-recommends \
> - bison \
> - build-essential \
> - ca-certificates \
> - clang \
> - debian-ports-archive-keyring \
> - flex \
> - gettext \
> - git \
> - pkg-config \
> - psmisc \
> - python \
> - texinfo \
> - $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\
> -f2)
>
- [PATCH v3 10/33] migration/postcopy: Recognise the recovery states as 'in_postcopy', (continued)
- [PATCH v3 10/33] migration/postcopy: Recognise the recovery states as 'in_postcopy', Alex Bennée, 2019/09/24
- [PATCH v3 09/33] tests/migration/postcopy: trim migration bandwidth, Alex Bennée, 2019/09/24
- [PATCH v3 27/33] docker: remove debian8-mxe definitions, Alex Bennée, 2019/09/24
- [PATCH v3 17/33] tests/tcg: clean-up some comments after the de-tangling, Alex Bennée, 2019/09/24
- [PATCH v3 18/33] tests/tcg: re-enable linux-test for ppc64abi32, Alex Bennée, 2019/09/24
- [PATCH v3 30/33] docker: remove unused debian-ports, Alex Bennée, 2019/09/24
- Re: [PATCH v3 30/33] docker: remove unused debian-ports,
Philippe Mathieu-Daudé <=
- [PATCH v3 24/33] target/i386: Fix broken build with WHPX enabled, Alex Bennée, 2019/09/24
- [PATCH v3 14/33] tests/docker: remove python2.7 from debian9-mxe, Alex Bennée, 2019/09/24
- [PATCH v3 28/33] docker: removed unused debian8 partial image, Alex Bennée, 2019/09/24
- [PATCH v3 23/33] docs/devel: add "check-tcg" to testing.rst, Alex Bennée, 2019/09/24
- [PATCH v3 26/33] .shippable.yml: Build WHPX enabled binaries, Alex Bennée, 2019/09/24
- [PATCH v3 22/33] configure: preserve PKG_CONFIG for subdir builds, Alex Bennée, 2019/09/24