[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery |
|
Date: |
Tue, 24 Sep 2019 19:29:53 +0100 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Markus Armbruster (address@hidden) wrote:
> migration-tests hangs intermittently for me, and git bisect led me
> here. Test script:
>
> i=0; while true; do let i++; echo "= $i =";
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
> tests/migration-test -p /x86_64/migration/postcopy/recovery -k; done
Which is fixed by the patch I posted yesterday:
migration/postcopy: Recognise the recovery states as 'in_postcopy'
Good working finding it using a bisect - it was way too unreliable
for me to find repeatably.
The 'Fix postcopy bw for recovery' patch is actually right - it just
exposes another existing race.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK