Re: [PULL 4/4] tests: Use iothreads during iotest 223

[Eric Blake]

On 9/24/19 8:49 AM, Nir Soffer wrote:
> On Tue, Sep 24, 2019 at 4:18 PM Eric Blake <address@hidden> wrote:
> 
>> Doing so catches the bugs we just fixed with NBD not properly using
>> correct contexts.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>> Message-Id: <address@hidden>
>> ---
>>  tests/qemu-iotests/223     | 6 ++++--
>>  tests/qemu-iotests/223.out | 1 +
>>  2 files changed, 5 insertions(+), 2 deletions(-)

>> -_launch_qemu 2> >(_filter_nbd)
>> +_launch_qemu -object iothread,id=io0 2> >(_filter_nbd)
>>
> 
> But now we will not catch bugs in flows that do not use iothreads.
> 
> I think it will be better to run this test twice, one with iothreads, one
> without.

Too late for this pull request, but I will propose that as a followup patch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature