[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] memory: allow memory_region_register_iommu_notifier()
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v3 2/2] memory: allow memory_region_register_iommu_notifier() to fail |
|
Date: |
Mon, 23 Sep 2019 15:59:30 +0800 |
|
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, Sep 23, 2019 at 08:55:52AM +0200, Eric Auger wrote:
> Currently, when a notifier is attempted to be registered and its
> flags are not supported (especially the MAP one) by the IOMMU MR,
> we generally abruptly exit in the IOMMU code. The failure could be
> handled more nicely in the caller and especially in the VFIO code.
>
> So let's allow memory_region_register_iommu_notifier() to fail as
> well as notify_flag_changed() callback.
>
> All sites implementing the callback are updated. This patch does
> not yet remove the exit(1) in the amd_iommu code.
>
> in SMMUv3 we turn the warning message into an error message saying
> that the assigned device would not work properly.
>
> Signed-off-by: Eric Auger <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
--
Peter Xu