[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] riscv: sifive_u: Drop "clock-frequency" property of cpu
From: |
Alistair Francis |
Subject: |
Re: [PATCH 1/2] riscv: sifive_u: Drop "clock-frequency" property of cpu nodes |
Date: |
Fri, 20 Sep 2019 11:46:38 -0700 |
On Fri, Sep 20, 2019 at 2:26 AM Bin Meng <address@hidden> wrote:
>
> The "clock-frequency" property of cpu nodes isn't required. Drop it.
>
> This is to keep in sync with Linux kernel commit below:
> https://patchwork.kernel.org/patch/11133031/
>
> Signed-off-by: Bin Meng <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
>
> hw/riscv/sifive_u.c | 2 --
> include/hw/riscv/sifive_u.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
> index 9f8e84b..02dd761 100644
> --- a/hw/riscv/sifive_u.c
> +++ b/hw/riscv/sifive_u.c
> @@ -151,8 +151,6 @@ static void create_fdt(SiFiveUState *s, const struct
> MemmapEntry *memmap,
> char *intc = g_strdup_printf("/cpus/cpu@%d/interrupt-controller",
> cpu);
> char *isa;
> qemu_fdt_add_subnode(fdt, nodename);
> - qemu_fdt_setprop_cell(fdt, nodename, "clock-frequency",
> - SIFIVE_U_CLOCK_FREQ);
> /* cpu 0 is the management hart that does not have mmu */
> if (cpu != 0) {
> qemu_fdt_setprop_string(fdt, nodename, "mmu-type", "riscv,sv48");
> diff --git a/include/hw/riscv/sifive_u.h b/include/hw/riscv/sifive_u.h
> index e4df298..4850805 100644
> --- a/include/hw/riscv/sifive_u.h
> +++ b/include/hw/riscv/sifive_u.h
> @@ -75,7 +75,6 @@ enum {
> };
>
> enum {
> - SIFIVE_U_CLOCK_FREQ = 1000000000,
> SIFIVE_U_HFCLK_FREQ = 33333333,
> SIFIVE_U_RTCCLK_FREQ = 1000000
> };
> --
> 2.7.4
>
>