[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vhost-user-gpu: Drop trailing json comma
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] vhost-user-gpu: Drop trailing json comma |
|
Date: |
Fri, 20 Sep 2019 11:06:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 9/19/19 10:33 PM, Cole Robinson wrote:
> Trailing comma is not valid json:
>
> $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq
> parse error: Expected another key-value pair at line 5, column 1
Shouldn't we add this as a test?
> Signed-off-by: Cole Robinson <address@hidden>
> ---
> contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> index 658b545864..f5edd097f8 100644
> --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> @@ -1,5 +1,5 @@
> {
> "description": "QEMU vhost-user-gpu",
> "type": "gpu",
> - "binary": "@libexecdir@/vhost-user-gpu",
> + "binary": "@libexecdir@/vhost-user-gpu"
> }
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>