qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 31/45] tests/docker: add more images to PARTIAL_IMAGES when no


From: Philippe Mathieu-Daudé
Subject: Re: [PULL 31/45] tests/docker: add more images to PARTIAL_IMAGES when not on x86_64
Date: Thu, 19 Sep 2019 22:18:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

Hi Alex,

On 9/10/19 10:43 AM, Alex Bennée wrote:
> This prevents us trying to do builds which we can't complete.
> 
> Signed-off-by: Alex Bennée <address@hidden>
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 7df8dbe1a17..50a400b573a 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -106,6 +106,15 @@ docker-image-debian-s390x-cross: docker-image-debian9
>  docker-image-debian-win32-cross: docker-image-debian9-mxe
>  docker-image-debian-win64-cross: docker-image-debian9-mxe
>  
> +# For non-x86 hosts not all cross-compilers have been packaged
> +ifneq ($(ARCH),x86_64)
> +DOCKER_PARTIAL_IMAGES += debian-mips-cross debian-mipsel-cross 
> debian-mips64el-cross
> +DOCKER_PARTIAL_IMAGES += debian-ppc64el-cross
> +DOCKER_PARTIAL_IMAGES += debian-s390x-cross
> +DOCKER_PARTIAL_IMAGES += debian-win32-cross debian-win64-cross
> +DOCKER_PARTIAL_IMAGES += fedora travis
> +endif
> +
>  docker-image-debian-alpha-cross: docker-image-debian10
>  docker-image-debian-arm64-cross: docker-image-debian10
>  docker-image-debian-hppa-cross: docker-image-debian10
> 

I wanted to run the Travis tests locally (per
docs/devel/testing.rst:364) but I got:

$ make docker-travis@travis
  LD      address@hidden
cc: fatal error: no input files
compilation terminated.
make: *** [rules.mak:118: address@hidden] Error 1

Bisected to this patch:

e5389e44147e4c8d652006ed086c48f74684726a is the first bad commit
commit e5389e44147e4c8d652006ed086c48f74684726a
Author: Alex Bennée <address@hidden>
Date:   Thu Aug 15 19:40:48 2019 +0000

    tests/docker: add more images to PARTIAL_IMAGES when not on x86_64

    This prevents us trying to do builds which we can't complete.

Removing 'travis' from this list we get it working again.

Regards,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]