[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 4/5] vhost: assert on memory_region_register_iomm
From: |
Eric Auger |
Subject: |
[Qemu-devel] [PATCH v2 4/5] vhost: assert on memory_region_register_iommu_notifier() failure |
Date: |
Thu, 19 Sep 2019 14:18:44 +0200 |
memory_region_register_iommu_notifier now returns an error
in case of failure. Assert in such a case.
Signed-off-by: Eric Auger <address@hidden>
---
v1 -> v2:
- assert(!ret)
---
hw/virtio/vhost.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 34accdf615..975cb4c28c 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -672,7 +672,7 @@ static void vhost_iommu_region_add(MemoryListener *listener,
iommu_listener);
struct vhost_iommu *iommu;
Int128 end;
- int iommu_idx;
+ int iommu_idx, ret;
IOMMUMemoryRegion *iommu_mr;
if (!memory_region_is_iommu(section->mr)) {
@@ -696,7 +696,8 @@ static void vhost_iommu_region_add(MemoryListener *listener,
iommu->iommu_offset = section->offset_within_address_space -
section->offset_within_region;
iommu->hdev = dev;
- memory_region_register_iommu_notifier(section->mr, &iommu->n);
+ ret = memory_region_register_iommu_notifier(section->mr, &iommu->n);
+ assert(!ret);
QLIST_INSERT_HEAD(&dev->iommu_list, iommu, iommu_next);
/* TODO: can replay help performance here? */
}
--
2.20.1
- [Qemu-devel] [PATCH v2 0/5] Allow memory_region_register_iommu_notifier() to fail, Eric Auger, 2019/09/19
- [Qemu-devel] [PATCH v2 2/5] vfio/common: Handle memory_region_register_iommu_notifier() failure, Eric Auger, 2019/09/19
- [Qemu-devel] [PATCH v2 1/5] memory: allow memory_region_register_iommu_notifier() to fail, Eric Auger, 2019/09/19
- [Qemu-devel] [PATCH v2 3/5] exec: assert on memory_region_register_iommu_notifier() failure, Eric Auger, 2019/09/19
- [Qemu-devel] [PATCH v2 5/5] amd_iommu: Let amdvi_iommu_notify_flag_changed() fail, Eric Auger, 2019/09/19
- [Qemu-devel] [PATCH v2 4/5] vhost: assert on memory_region_register_iommu_notifier() failure,
Eric Auger <=
- Re: [PATCH v2 0/5] Allow memory_region_register_iommu_notifier() to fail, Peter Xu, 2019/09/20