[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/19] tests/qapi-schema: Demonstrate broken dis
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/19] tests/qapi-schema: Demonstrate broken discriminator errors |
Date: |
Tue, 17 Sep 2019 12:43:40 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/14/19 10:34 AM, Markus Armbruster wrote:
> When the union definition's base is an object, some error messages
> show it as an OrderedDict. Oops. Mark FIXME.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/qapi-schema/flat-union-invalid-discriminator.err | 2 +-
> tests/qapi-schema/flat-union-invalid-discriminator.json | 6 ++----
> tests/qapi-schema/flat-union-invalid-if-discriminator.err | 2 +-
> tests/qapi-schema/flat-union-invalid-if-discriminator.json | 6 ++----
> 4 files changed, 6 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 10/19] qapi: Fix broken discriminator error messages, (continued)
- [Qemu-devel] [PATCH 02/19] tests/qapi-schema: Delete two redundant tests, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 08/19] qapi: Improve reporting of lexical errors, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 11/19] qapi: Reject blank 'if' conditions in addition to empty ones, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 06/19] tests/qapi-schema: Demonstrate suboptimal lexical errors, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 04/19] tests/qapi-schema: Demonstrate broken discriminator errors, Markus Armbruster, 2019/09/14
- Re: [Qemu-devel] [PATCH 04/19] tests/qapi-schema: Demonstrate broken discriminator errors,
Eric Blake <=
- [Qemu-devel] [PATCH 18/19] qapi: Fix excessive QAPISchemaEntity.check() recursion, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 19/19] qapi: Assert .visit() and .check_clash() run only after .check(), Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 16/19] qapi: Delete useless check_exprs() code for simple union kind, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 15/19] qapi: Clean up around check_known_keys(), Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 17/19] qapi: Fix to .check() empty structs just once, Markus Armbruster, 2019/09/14