Re: [Qemu-devel] [PATCH] hw/arm: set machine 'virt' as default

[Dan Streetman]

On Tue, Sep 17, 2019 at 1:24 PM Dan Streetman
<address@hidden> wrote:
>
> From: Dan Streetman <address@hidden>
>
> There is currently no default machine type for arm so one must be specified
> with --machine.  This sets the 'virt' machine type as default.

just to clarify why anyone would care if there's a default or not, in
case it's not clear, I have a bit more reasoning here:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1844357

Specifically for my use case, I'm enabling systemd's unit tests to run
on Ubuntu testbeds for different archs (x86_64, i386, ppc64el, arm64,
s390x) and arm64 is the only arch where we need to specify a machine
type; all the rest have a default machine type that works fine.  I'd
prefer if we didn't have to specify a machine type for any of the
archs.

For reference, this is the systemd PR to enable use of qemu for all
the archs we have testbeds for:
https://github.com/systemd/systemd/pull/13409

>
> Signed-off-by: Dan Streetman <address@hidden>
> ---
>  hw/arm/virt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index d74538b021..e9fe888ca2 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -78,6 +78,7 @@
>          mc->desc = "QEMU " # major "." # minor " ARM Virtual Machine"; \
>          if (latest) { \
>              mc->alias = "virt"; \
> +            mc->is_default = 1; \
>          } \
>      } \
>      static const TypeInfo machvirt_##major##_##minor##_info = { \
> --
> 2.20.1
>