[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093
From: |
Andrey Shinkevich |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093 |
Date: |
Tue, 17 Sep 2019 14:25:18 +0000 |
On 17/09/2019 12:20, Max Reitz wrote:
> null-aio may not be whitelisted. Skip all test cases that require it.
>
> (And skip the whole test if null-co is not whitelisted.)
This solution has been persisting since v1. Nevertheless, I am still not
clear why not to run the test if the null-aio is the only whitelisted
driver? Will the null-aio be supported in future?
Andrey
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/093 | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/093 b/tests/qemu-iotests/093
> index 50c1e7f2ec..f03fa24a07 100755
> --- a/tests/qemu-iotests/093
> +++ b/tests/qemu-iotests/093
> @@ -24,7 +24,7 @@ import iotests
> nsec_per_sec = 1000000000
>
> class ThrottleTestCase(iotests.QMPTestCase):
> - test_img = "null-aio://"
> + test_driver = "null-aio"
> max_drives = 3
>
> def blockstats(self, device):
> @@ -35,10 +35,14 @@ class ThrottleTestCase(iotests.QMPTestCase):
> return stat['rd_bytes'], stat['rd_operations'],
> stat['wr_bytes'], stat['wr_operations']
> raise Exception("Device not found for blockstats: %s" % device)
>
> + def required_drivers(self):
> + return [self.test_driver]
> +
> + @iotests.skip_if_unsupported(required_drivers)
> def setUp(self):
> self.vm = iotests.VM()
> for i in range(0, self.max_drives):
> - self.vm.add_drive(self.test_img, "file.read-zeroes=on")
> + self.vm.add_drive(self.test_driver + "://",
> "file.read-zeroes=on")
> self.vm.launch()
>
> def tearDown(self):
> @@ -264,7 +268,7 @@ class ThrottleTestCase(iotests.QMPTestCase):
> self.assertEqual(self.blockstats('drive1')[0], 4096)
>
> class ThrottleTestCoroutine(ThrottleTestCase):
> - test_img = "null-co://"
> + test_driver = "null-co"
>
> class ThrottleTestGroupNames(iotests.QMPTestCase):
> max_drives = 3
> @@ -425,4 +429,6 @@ class ThrottleTestRemovableMedia(iotests.QMPTestCase):
>
>
> if __name__ == '__main__':
> + if 'null-co' not in iotests.supported_formats():
> + iotests.notrun('null-co driver support missing')
> iotests.main(supported_fmts=["raw"])
>
Reviewed-by: Andrey Shinkevich <address@hidden>
--
With the best regards,
Andrey Shinkevich
- [Qemu-devel] [PATCH v4 0/7] iotests: Selfish patches, Max Reitz, 2019/09/17
- [Qemu-devel] [PATCH v4 1/7] iotests: Prefer null-co over null-aio, Max Reitz, 2019/09/17
- [Qemu-devel] [PATCH v4 2/7] iotests: Allow skipping test cases, Max Reitz, 2019/09/17
- [Qemu-devel] [PATCH v4 3/7] iotests: Use case_skip() in skip_if_unsupported(), Max Reitz, 2019/09/17
- [Qemu-devel] [PATCH v4 4/7] iotests: Let skip_if_unsupported accept a function, Max Reitz, 2019/09/17
- [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093, Max Reitz, 2019/09/17
- Re: [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093,
Andrey Shinkevich <=
- Re: [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093, John Snow, 2019/09/18
- [Qemu-devel] [PATCH v4 6/7] iotests: Test driver whitelisting in 136, Max Reitz, 2019/09/17
- [Qemu-devel] [PATCH v4 7/7] iotests: Cache supported_formats(), Max Reitz, 2019/09/17