[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 14/17] ccid-card-emul: Pass local error object point
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PATCH 14/17] ccid-card-emul: Pass local error object pointer to error_append_hint() |
Date: |
Tue, 17 Sep 2019 12:21:59 +0200 |
User-agent: |
StGit/unknown-version |
Ensure that hints are added even if errp is &error_fatal or &error_abort.
Signed-off-by: Greg Kurz <address@hidden>
---
hw/usb/ccid-card-emulated.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
index 291e41db8a1e..3bc397341090 100644
--- a/hw/usb/ccid-card-emulated.c
+++ b/hw/usb/ccid-card-emulated.c
@@ -511,10 +511,13 @@ static void emulated_realize(CCIDCardState *base, Error
**errp)
}
if (card->backend == 0) {
- error_setg(errp, "backend must be one of:");
+ Error *local_err = NULL;
+
+ error_setg(&local_err, "backend must be one of:");
for (ptable = backend_enum_table; ptable->name != NULL; ++ptable) {
- error_append_hint(errp, "%s\n", ptable->name);
+ error_append_hint(&local_err, "%s\n", ptable->name);
}
+ error_propagate(errp, local_err);
goto out2;
}
- Re: [Qemu-devel] [PATCH 09/17] hw/rdma: Fix missing conversion to rdma_error_report(), (continued)
- [Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 11/17] scsi: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 12/17] migration: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 13/17] nbd: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 14/17] ccid-card-emul: Pass local error object pointer to error_append_hint(),
Greg Kurz <=
- [Qemu-devel] [PATCH 15/17] option: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 16/17] socket: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 17/17] checkpatch: Warn when errp is passed to error_append_hint(), Greg Kurz, 2019/09/17
- Re: [Qemu-devel] [PATCH 00/17] Fix usage of error_append_hint(), Philippe Mathieu-Daudé, 2019/09/17