Re: [Qemu-devel] [PATCH v4 2/4] iotest 258: use script_main

[Vladimir Sementsov-Ogievskiy]

12.09.2019 3:16, John Snow wrote:
> Since this one is nicely factored to use a single entry point,
> use script_main to run the tests.
> 
> Signed-off-by: John Snow <address@hidden>

Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

> ---
>   tests/qemu-iotests/258 | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/qemu-iotests/258 b/tests/qemu-iotests/258
> index b84cf02254..1372522c7a 100755
> --- a/tests/qemu-iotests/258
> +++ b/tests/qemu-iotests/258
> @@ -23,11 +23,6 @@ import iotests
>   from iotests import log, qemu_img, qemu_io_silent, \
>           filter_qmp_testfiles, filter_qmp_imgfmt
>   
> -# Need backing file and change-backing-file support
> -iotests.verify_image_format(supported_fmts=['qcow2', 'qed'])
> -iotests.verify_platform(['linux'])
> -
> -
>   # Returns a node for blockdev-add
>   def node(node_name, path, backing=None, fmt=None, throttle=None):
>       if fmt is None:
> @@ -160,4 +155,5 @@ def main():
>       test_concurrent_finish(False)
>   
>   if __name__ == '__main__':
> -    main()
> +    # Need backing file and change-backing-file support
> +    iotests.script_main(main, supported_fmts=['qcow2', 'qed'])
> 


-- 
Best regards,
Vladimir