[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events |
|
Date: |
Mon, 16 Sep 2019 11:36:55 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote:
> While the tracing frawework does not forbid trailing newline in
framework
> events format string, using them lead to confuse output.
> It is the responsibility of the backend to properly end an event
> line.
Why just trailing newline? Should we not forbid ALL use of newline in a
trace message?
>
> Some of our formats have trailing newlines, remove them.
>
> Reviewed-by: John Snow <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 2/2] trace: Forbid event format ending with newline character, Philippe Mathieu-Daudé, 2019/09/16
Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] trace: Forbid trailing newline in event format, Stefan Hajnoczi, 2019/09/18