[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/4] intel_iommu: Sanity check vfio-pci conf
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/4] intel_iommu: Sanity check vfio-pci config on machine init done |
Date: |
Mon, 16 Sep 2019 15:56:09 +0800 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, Sep 16, 2019 at 09:11:50AM +0200, Auger Eric wrote:
> > static void vtd_realize(DeviceState *dev, Error **errp)
> > {
> > MachineState *ms = MACHINE(qdev_get_machine());
> > @@ -3741,6 +3772,7 @@ static void vtd_realize(DeviceState *dev, Error
> > **errp)
> > pci_setup_iommu(bus, vtd_host_dma_iommu, dev);
> > /* Pseudo address space under root PCI bus. */
> > pcms->ioapic_as = vtd_host_dma_iommu(bus, s, Q35_PSEUDO_DEVFN_IOAPIC);
> > + qemu_add_machine_init_done_notifier(&vtd_machine_done_notify);
> This does not compile anymore on master. I think sysemu/sysemu.h needs
> to be included as declaration of qemu_add_machine_init_done_notifier is
> not found.
Indeed. It's probably because we've changed some header inclusions
recently between each other. I'll repost a new version with it added.
>
> Besides
> Reviewed-by: Eric Auger <address@hidden>
Thanks for the reviews!
--
Peter Xu