[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 22/24] usb-audio: do not count on avail bytes act
From: |
Kővágó, Zoltán |
Subject: |
[Qemu-devel] [PATCH v3 22/24] usb-audio: do not count on avail bytes actually available |
Date: |
Sun, 15 Sep 2019 21:23:38 +0200 |
This assumption is no longer true when mixeng is turned off.
Signed-off-by: Kővágó, Zoltán <address@hidden>
---
hw/usb/dev-audio.c | 28 +++++++++++++++++-----------
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
index ae42e5a2f1..74c99b1f12 100644
--- a/hw/usb/dev-audio.c
+++ b/hw/usb/dev-audio.c
@@ -319,30 +319,31 @@ static int streambuf_put(struct streambuf *buf, USBPacket
*p)
{
uint32_t free = buf->size - (buf->prod - buf->cons);
- if (!free) {
+ if (free < USBAUDIO_PACKET_SIZE) {
return 0;
}
if (p->iov.size != USBAUDIO_PACKET_SIZE) {
return 0;
}
- assert(free >= USBAUDIO_PACKET_SIZE);
+
usb_packet_copy(p, buf->data + (buf->prod % buf->size),
USBAUDIO_PACKET_SIZE);
buf->prod += USBAUDIO_PACKET_SIZE;
return USBAUDIO_PACKET_SIZE;
}
-static uint8_t *streambuf_get(struct streambuf *buf)
+static uint8_t *streambuf_get(struct streambuf *buf, size_t *len)
{
uint32_t used = buf->prod - buf->cons;
uint8_t *data;
if (!used) {
+ *len = 0;
return NULL;
}
- assert(used >= USBAUDIO_PACKET_SIZE);
data = buf->data + (buf->cons % buf->size);
- buf->cons += USBAUDIO_PACKET_SIZE;
+ *len = MIN(buf->prod - buf->cons,
+ buf->size - (buf->cons % buf->size));
return data;
}
@@ -374,16 +375,21 @@ static void output_callback(void *opaque, int avail)
USBAudioState *s = opaque;
uint8_t *data;
- for (;;) {
- if (avail < USBAUDIO_PACKET_SIZE) {
+ while (avail) {
+ size_t written, len;
+
+ data = streambuf_get(&s->out.buf, &len);
+ if (!data) {
return;
}
- data = streambuf_get(&s->out.buf);
- if (!data) {
+
+ written = AUD_write(s->out.voice, data, len);
+ avail -= written;
+ s->out.buf.cons += written;
+
+ if (written < len) {
return;
}
- AUD_write(s->out.voice, data, USBAUDIO_PACKET_SIZE);
- avail -= USBAUDIO_PACKET_SIZE;
}
}
--
2.23.0
- [Qemu-devel] [PATCH v3 10/24] wavaudio: port to the new audio backend api, (continued)
- [Qemu-devel] [PATCH v3 10/24] wavaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 07/24] paaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 11/24] audio: remove remains of the old backend api, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 12/24] audio: unify input and output mixeng buffer management, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 13/24] audio: common rate control code for timer based outputs, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 15/24] audio: add mixeng option (documentation), Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 16/24] audio: make mixeng optional, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 20/24] audio: basic support for multichannel audio, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 18/24] audio: support more than two channels in volume setting, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 17/24] paaudio: get/put_buffer functions, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 22/24] usb-audio: do not count on avail bytes actually available,
Kővágó, Zoltán <=
- [Qemu-devel] [PATCH v3 14/24] audio: split ctl_* functions into enable_* and volume_*, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 19/24] audio: replace shift in audio_pcm_info with bytes_per_frame, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 21/24] paaudio: channel-map option, Kővágó, Zoltán, 2019/09/15
- [Qemu-devel] [PATCH v3 24/24] usbaudio: change playback counters to 64 bit, Kővágó, Zoltán, 2019/09/15