[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 0/9] hw/m68k: add Apple Machintosh Quadra 80
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v12 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine |
Date: |
Sun, 15 Sep 2019 08:55:34 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v12 0/9] hw/m68k: add Apple Machintosh Quadra 800
machine
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0817364 BootLinuxConsoleTest: Test the Quadra 800
e3ae75d hw/m68k: define Macintosh Quadra 800
67a53c2 hw/m68k: add a dummy SWIM floppy controller
3fd4027 hw/m68k: add Nubus macfb video card
41c0c2d hw/m68k: add Nubus support
8cef3ab hw/m68k: implement ADB bus support for via
8866195 hw/m68k: add VIA support
7cb4bc9 dp8393x: manage big endian bus
cf809aa esp: add pseudo-DMA as used by Macintosh
=== OUTPUT BEGIN ===
1/9 Checking commit cf809aadb332 (esp: add pseudo-DMA as used by Macintosh)
2/9 Checking commit 7cb4bc912a2a (dp8393x: manage big endian bus)
3/9 Checking commit 886619516636 (hw/m68k: add VIA support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#83:
new file mode 100644
ERROR: space prohibited after that '&&' (ctx:WxW)
#432: FILE: hw/misc/mac_via.c:345:
+ if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) {
^
total: 1 errors, 1 warnings, 866 lines checked
Patch 3/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/9 Checking commit 8cef3abea375 (hw/m68k: implement ADB bus support for via)
5/9 Checking commit 41c0c2d63044 (hw/m68k: add Nubus support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#64:
new file mode 100644
total: 0 errors, 1 warnings, 531 lines checked
Patch 5/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit 3fd4027a6a22 (hw/m68k: add Nubus macfb video card)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#75:
new file mode 100644
total: 0 errors, 1 warnings, 597 lines checked
Patch 6/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/9 Checking commit 67a53c240e07 (hw/m68k: add a dummy SWIM floppy controller)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62:
new file mode 100644
total: 0 errors, 1 warnings, 591 lines checked
Patch 7/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/9 Checking commit e3ae75d63264 (hw/m68k: define Macintosh Quadra 800)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
new file mode 100644
total: 0 errors, 1 warnings, 530 lines checked
Patch 8/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/9 Checking commit 08173643dd93 (BootLinuxConsoleTest: Test the Quadra 800)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v12 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 1/9] esp: add pseudo-DMA as used by Macintosh, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 4/9] hw/m68k: implement ADB bus support for via, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 2/9] dp8393x: manage big endian bus, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 5/9] hw/m68k: add Nubus support, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 9/9] BootLinuxConsoleTest: Test the Quadra 800, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 8/9] hw/m68k: define Macintosh Quadra 800, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 3/9] hw/m68k: add VIA support, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 6/9] hw/m68k: add Nubus macfb video card, Laurent Vivier, 2019/09/15
- [Qemu-devel] [PATCH v12 7/9] hw/m68k: add a dummy SWIM floppy controller, Laurent Vivier, 2019/09/15
- Re: [Qemu-devel] [PATCH v12 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine,
no-reply <=