Re: [Qemu-devel] [PATCH] error-report: Add info_report_once helper

[Cyrill Gorcunov]

On Sat, Sep 14, 2019 at 08:40:40PM +0200, Markus Armbruster wrote:
> You neglected to cc: the maintainer (me).  I spotted this anyway, more
> or less by chance.  Next time, please use scripts/get_maintainer.pl to
> find people you might want to cc:.

Ah, sorry for that. Will do next time, thanks!

> Cyrill Gorcunov <address@hidden> writes:
> 
> > We already have error_report_once and warn_report_once,
> > thus lets add info_report_once to complement. Actually
> > I use this helper a lot so might be usefull for others.
> >
> > Signed-off-by: Cyrill Gorcunov <address@hidden>
> 
> Patch looks reasonable enough.  However, the new info_report_once() and
> info_report_once_cond() aren't used.  Your commit message suggests you
> have users in unpublished code.  Is that correct?

Exactly. I work on yet unpublished but open source code
(https://src.openvz.org/projects/UP/repos/qemu/browse) to be
precise. But work is still in progress and hasn't been pushed
out.

You know I posted the patch simply because it might be
useful for someone and it looks a bit incomplete that
we have "warn/error once" but no info_once. Up to you
to decide if we need it in vanilla tree.