[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock |
Date: |
Wed, 11 Sep 2019 18:13:15 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Daniel P. Berrangé (address@hidden) wrote:
> On Wed, Sep 11, 2019 at 05:41:59PM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > This patch uses glib's g_auto mechanism to automatically free
> > rcu_read_lock's at the end of the block. Given that humans
> > have a habit of forgetting an error path somewhere it's
> > best to leave it to the compiler.
> >
> > In particular:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1746787
> > suggests we've forgotten an unlock case somewhere in the
> > rdma migration code.
>
> Probably worth mentioning this in the commit message of the 3rd patch
> so someone reading history sees that the patch wasn't just a no-op
> conversion, but instead actively fixing a bug.
Added.
Dave
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant, (continued)
[Qemu-devel] [PATCH 2/3] migration: Use automatic rcu_read unlock in ram.c, Dr. David Alan Gilbert (git), 2019/09/11
[Qemu-devel] [PATCH 3/3] migration: Use automatic rcu_read unlock in rdma.c, Dr. David Alan Gilbert (git), 2019/09/11
Re: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock, Daniel P . Berrangé, 2019/09/11
- Re: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock,
Dr. David Alan Gilbert <=
Re: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock, no-reply, 2019/09/11