[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/17] RISC-V: support vector extension
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/17] RISC-V: support vector extension |
Date: |
Wed, 11 Sep 2019 09:00:56 +0200 |
11.09.2019. 08.35, "liuzhiwei" <address@hidden> је написао/ла:
>
> Features:
> * support specification riscv-v-spec-0.7.1(
https://content.riscv.org/wp-content/uploads/2019/06/17.40-Vector_RISCV-20190611-Vectors.pdf
).
Hi, Zhivei.
The linked document is a presentation, outlining general concepts of the
instruction set in question, which is certainly useful and nice to have,
but, for review process, we need *specifications* (especially given that
they are in draft phase, and therefore "moving target"). Please provide
such link.
I also noticed lack of commit messages, and was really disappointed by
that. It looks to me you did not honor in entirety our guidlines for
submitting patches.
Yours,
Aleksandar
> * support basic vector extension.
> * support Zvlsseg.
> * support Zvamo.
> * not support Zvediv as it is changing.
> * fixed VLEN 128bit.
> * fixed SLEN 128bit.
> * ELEN support 8bit, 16bit, 32bit, 64bit.
>
> Todo:
> * support VLEN configure from qemu command line.
> * move check code from execution-time to translation-time
>
> Changelog:
> V2
> * use float16_compare{_quiet}
> * only use GETPC() in outer most helper
> * add ctx.ext_v Property
>
>
> LIU Zhiwei (17):
> RISC-V: add vfp field in CPURISCVState
> RISC-V: turn on vector extension from command line by cfg.ext_v
> Property
> RISC-V: support vector extension csr
> RISC-V: add vector extension configure instruction
> RISC-V: add vector extension load and store instructions
> RISC-V: add vector extension fault-only-first implementation
> RISC-V: add vector extension atomic instructions
> RISC-V: add vector extension integer instructions part1,
> add/sub/adc/sbc
> RISC-V: add vector extension integer instructions part2, bit/shift
> RISC-V: add vector extension integer instructions part3, cmp/min/max
> RISC-V: add vector extension integer instructions part4, mul/div/merge
> RISC-V: add vector extension fixed point instructions
> RISC-V: add vector extension float instruction part1, add/sub/mul/div
> RISC-V: add vector extension float instructions part2,
> sqrt/cmp/cvt/others
> RISC-V: add vector extension reduction instructions
> RISC-V: add vector extension mask instructions
> RISC-V: add vector extension premutation instructions
>
> linux-user/riscv/cpu_loop.c | 7 +
> target/riscv/Makefile.objs | 2 +-
> target/riscv/cpu.c | 6 +-
> target/riscv/cpu.h | 30 +
> target/riscv/cpu_bits.h | 15 +
> target/riscv/cpu_helper.c | 7 +
> target/riscv/csr.c | 65 +-
> target/riscv/helper.h | 358 +
> target/riscv/insn32.decode | 373 +
> target/riscv/insn_trans/trans_rvv.inc.c | 490 +
> target/riscv/translate.c | 1 +
> target/riscv/vector_helper.c | 25701
++++++++++++++++++++++++++++++
> 12 files changed, 27049 insertions(+), 6 deletions(-)
> create mode 100644 target/riscv/insn_trans/trans_rvv.inc.c
> create mode 100644 target/riscv/vector_helper.c
>
> --
> 2.7.4
>
>
- [Qemu-devel] [PATCH v2 16/17] RISC-V: add vector extension mask instructions, (continued)
- [Qemu-devel] [PATCH v2 16/17] RISC-V: add vector extension mask instructions, liuzhiwei, 2019/09/11
- [Qemu-devel] [PATCH v2 17/17] RISC-V: add vector extension premutation instructions, liuzhiwei, 2019/09/11
- [Qemu-devel] [PATCH v2 15/17] RISC-V: add vector extension reduction instructions, liuzhiwei, 2019/09/11
- [Qemu-devel] [PATCH v2 12/17] RISC-V: add vector extension fixed point instructions, liuzhiwei, 2019/09/11
- [Qemu-devel] [PATCH v2 13/17] RISC-V: add vector extension float instruction part1, add/sub/mul/div, liuzhiwei, 2019/09/11
- [Qemu-devel] [PATCH v2 14/17] RISC-V: add vector extension float instructions part2, sqrt/cmp/cvt/others, liuzhiwei, 2019/09/11
- [Qemu-devel] [PATCH v2 11/17] RISC-V: add vector extension integer instructions part4, mul/div/merge, liuzhiwei, 2019/09/11
- Re: [Qemu-devel] [PATCH v2 00/17] RISC-V: support vector extension,
Aleksandar Markovic <=