[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter spec
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs |
Date: |
Mon, 9 Sep 2019 16:05:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Le 09/09/2019 à 16:00, Alex Bennée a écrit :
>
> Laurent Vivier <address@hidden> writes:
>
>> Le 30/08/2019 à 16:36, Alex Bennée a écrit :
>>> Just passing NULL means we end up ignoring the bad dfilter spec
>>> instead of reporting it and exiting as we should.
>>>
>>> Signed-off-by: Alex Bennée <address@hidden>
>>> ---
>>> linux-user/main.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/linux-user/main.c b/linux-user/main.c
>>> index 47917bbb20f..50a031520ca 100644
>>> --- a/linux-user/main.c
>>> +++ b/linux-user/main.c
>>> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
>>>
>>> static void handle_arg_dfilter(const char *arg)
>>> {
>>> - qemu_set_dfilter_ranges(arg, NULL);
>>> + qemu_set_dfilter_ranges(arg, &error_fatal);
>>> }
>>>
>>> static void handle_arg_log_filename(const char *arg)
>>>
>>
>> Reviewed-by: Laurent Vivier <address@hidden>
>
> Did you queue this or do you want me to resend?
I didn't but it's done now (no need to resend).
Thanks,
Laurent