Re: [Qemu-devel] [PATCH v3 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

[Philippe Mathieu-Daudé]

On 9/9/19 3:15 PM, Daniel P. Berrangé wrote:
> On Mon, Sep 09, 2019 at 02:57:08PM +0200, Philippe Mathieu-Daudé wrote:
>> On 8/29/19 6:50 PM, Daniel P. Berrangé wrote:
>>> Signed-off-by: Daniel P. Berrangé <address@hidden>
>>> ---
>>>  CODING_STYLE => CODING_STYLE.rst | 121 +++++++++++++++++++-----------
>>>  HACKING => HACKING.rst           | 123 +++++++++++++++++++++----------
>>>  README => README.rst             |  47 +++++++-----
>>>  scripts/checkpatch.pl            |   2 +-
>>>  4 files changed, 191 insertions(+), 102 deletions(-)
>>>  rename CODING_STYLE => CODING_STYLE.rst (72%)
>>>  rename HACKING => HACKING.rst (79%)
>>>  rename README => README.rst (84%)
>>
>> This change broke the NSIS build:
>>
>> (cd /tmp/qemu-nsis; \
>>          for i in qemu-system-*.exe; do \
>>            arch=${i%.exe}; \
>>            arch=${arch#qemu-system-}; \
>>            echo Section \"$arch\" Section_$arch; \
>>            echo SetOutPath \"\$INSTDIR\"; \
>>            echo File \"\${BINDIR}\\$i\"; \
>>            echo SectionEnd; \
>>          done \
>>         ) >/tmp/qemu-nsis/system-emulations.nsh
>> makensis -V2 -NOCD \
>>                 -DCONFIG_DOCUMENTATION="y" \
>>                 -DCONFIG_GTK="y" \
>>                 -DBINDIR="/tmp/qemu-nsis" \
>>                  \
>>                 -DSRCDIR="/tmp/qemu-test/src" \
>>                 -DOUTFILE="qemu-setup-4.1.50.exe" \
>>                 -DDISPLAYVERSION="4.1.50" \
>>                 /tmp/qemu-test/src/qemu.nsi
>> File: "/tmp/qemu-test/src\README" -> no files found.
>> Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] |
>>    /oname=outfile one_file_only)
>> Error in script "/tmp/qemu-test/src/qemu.nsi" on line 122 -- aborting
>> creation process
>> make: *** [Makefile:1083: qemu-setup-4.1.50.exe] Error 1
>>
>> I'll send a fix.
> 
> Doh. If we care about NSIS, we really need to have it being tested by
> some part of our CI system, and by pre-merge build tests.

I believe Stefan Weil does, since he regularly sends fixes or opens LP
bugs during freeze time.

We do build nsis/win32 with CI, but for some reason patchew was down.

I'm not sure we should duplicate the build on another CI, we should
rather setup something to watch patchew and warn us when it goes down.