qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize
Date: Mon, 9 Sep 2019 12:06:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 29.07.19 23:35, John Snow wrote:
> Like script_main, but doesn't require a single point of entry.
> Replace all existing initialization sections with this drop-in replacement.
> 
> This brings debug support to all existing script-style iotests.
> 
> Note: supported_oses=['linux'] was omitted, as it is a default argument.
> Signed-off-by: John Snow <address@hidden>
> ---

Looks good to me, but I’m afraid I looked at this series too late (that
is, now), so I sent my own version of your 2/3, sorry. :-/

That means that this needs a bit of rebasing and what remains of 2/3
afterwards (I haven’t converted existing tests using verify_protocol, so
that still needs to be done) should probably be squashed into this patch
here.

Max

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]