[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing viri
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p |
|
Date: |
Fri, 6 Sep 2019 13:22:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 05/09/2019 14.18, Greg Kurz wrote:
> On Thu, 5 Sep 2019 14:07:01 +0200
> Greg Kurz <address@hidden> wrote:
>
>> On Thu, 5 Sep 2019 13:33:46 +0200
>> Thomas Huth <address@hidden> wrote:
>>
>>> So far we were not testing virtio-9p in Travis yet, since we forgot to
>>> install libcap-devel. Do it now to get some more test coverage.
>>>
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> ---
>>
>> Acked-by: Greg Kurz <address@hidden>
>>
>
> Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests"
> section as well, near line 260 ?
Unless there is a test for 9p in the "check-acceptance" suite, it likely
does not make a difference - 9p would just get built one more additional
time, but it won't be tested afterwards.
Thomas