[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRE
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls |
Date: |
Fri, 6 Sep 2019 12:47:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
>
> FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands
> for controlling error reporting of a floppy drive.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> linux-user/ioctls.h | 2 ++
> linux-user/syscall_defs.h | 19 +++++++++++++++++++
> linux-user/syscall_types.h | 7 +++++++
> 3 files changed, 28 insertions(+)
>
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 622874b..0c75d03 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -118,6 +118,8 @@
> IOCTL(FDFMTTRK, IOC_W, MK_PTR(MK_STRUCT(STRUCT_format_descr)))
> IOCTL(FDFMTEND, 0, TYPE_NULL)
> IOCTL(FDFLUSH, 0, TYPE_NULL)
> + IOCTL(FDSETMAXERRS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_floppy_max_errors)))
> + IOCTL(FDGETMAXERRS, IOC_R, MK_PTR(MK_STRUCT(STRUCT_floppy_max_errors)))
where is FDSETEMSGTRESH?
> IOCTL(FDRESET, 0, TYPE_NULL)
> IOCTL(FDRAWCMD, 0, TYPE_NULL)
> IOCTL(FDTWADDLE, 0, TYPE_NULL)
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 834a085..7c5b614 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -890,12 +890,31 @@ struct target_pollfd {
>
> /* From <linux/fd.h> */
>
> +struct target_floppy_max_errors {
> + abi_uint abort;
> + abi_uint read_track;
> + abi_uint reset;
> + abi_uint recal;
> + abi_uint reporting;
> +};
You don't need this, you can use floppy_max_errors from <linux/fd.h>.
But you can define it if you want because it is used to know the size of
the target structure (and if alignment or data types differ it can
mismatch. With "int" it's not the case).
> +struct target_format_descr {
> + abi_uint device;
> + abi_uint head;
> + abi_uint track;
> +};
> +
This one is for the previous patch. Same comment as above.
Thanks,
Laurent
- Re: [Qemu-devel] [PATCH v6 3/8] linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls, (continued)
- [Qemu-devel] [PATCH v6 6/8] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls, Aleksandar Markovic, 2019/09/04
- Re: [Qemu-devel] [PATCH v6 6/8] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls, Laurent Vivier, 2019/09/06
- Re: [Qemu-devel] [PATCH v6 6/8] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PATCH v6 4/8] linux user: Add support for FDFLUSH ioctl, Aleksandar Markovic, 2019/09/04
- [Qemu-devel] [PATCH v6 5/8] linux-user: Add support for FDMSGON and FDMSGOFF ioctls, Aleksandar Markovic, 2019/09/04
- [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls, Aleksandar Markovic, 2019/09/04
- Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls,
Laurent Vivier <=
- Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls, Aleksandar Markovic, 2019/09/10
- Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls, Aleksandar Markovic, 2019/09/10
- Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls, Laurent Vivier, 2019/09/10
- Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls, Laurent Vivier, 2019/09/10
[Qemu-devel] [PATCH v6 7/8] linux-user: Add support for FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls, Aleksandar Markovic, 2019/09/04