Re: [Qemu-devel] [RFC v3 PATCH 07/45] multi-process: define proxy-link object

[Jag Raman]

On 9/5/2019 10:37 AM, Eric Blake wrote:
> On 9/4/19 3:22 AM, Daniel P. Berrangé wrote:
> > On Tue, Sep 03, 2019 at 04:37:33PM -0400, Jagannathan Raman wrote:
> > > Defines proxy-link object which forms the communication link between
> > > QEMU & emulation program.
> > > Adds functions to configure members of proxy-link object instance.
> > > Adds functions to send and receive messages over the communication
> > > channel.
> > > Adds GMainLoop to handle events received on the communication channel.
>
> > > +
> > > +#ifndef PROXY_LINK_H
> > > +#define PROXY_LINK_H
> > > +
> > > +#include <stddef.h>
> > > +#include <stdint.h>
> > > +#include <glib.h>
> >
> > I'm guessing this is the cause - nothing should be including this
> > directly - it is pulled  in for you via qemu/osdep.h
> >
> > > +#include <pthread.h>
> > > +
> > > +#include "qemu/osdep.h"
>
> For that matter, "qemu/osdep.h" should ALWAYS be listed first, before
> any system headers, and inclusion of <stddef.h> and <stdint.h> is also
> redundant, just as the <glib.h>.

Removing <glib.h> resolved the build issue. We'll remove <glib.h> in all
files in the next rev.

We soon realized the "qemu/osdep.h" should be the first include in all
the files. We'll ensure that this is the case for all files in the next
revision.

Thanks!
--
Jag

>