[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Virtio-fs] [PATCH RESEND 0/2] virtiofsd: use "fuse_log
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [Virtio-fs] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h> |
Date: |
Thu, 5 Sep 2019 11:36:13 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Philippe Mathieu-Daudé (address@hidden) wrote:
> Hi Stefan,
>
> On 9/5/19 10:29 AM, Stefan Hajnoczi wrote:
> > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the
> > --syslog
> > option was given. In this case messages to stderr are likely to be lost and
> > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of <err.h>.
> >
> > Stefan Hajnoczi (2):
> > virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
> > virtiofsd: replace err(3) and errx(3) with fuse_err()
>
> Is this a straight RESEND or are there any changes in this series?
>
> I'm asking because IIRC your first series had:
> - Reviewed-by: Jun Piao <address@hidden>
> - Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> If this isn't a RESEND then I'll review it again.
I'll pick those reviews up.
Dave
> Thanks,
>
> Phil.
>
> _______________________________________________
> Virtio-fs mailing list
> address@hidden
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK