[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/36] hw/intc/armv7m_nic: Access MemoryRegion with
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 05/36] hw/intc/armv7m_nic: Access MemoryRegion with MemOp |
Date: |
Tue, 3 Sep 2019 09:08:27 -0700 |
From: Tony Nguyen <address@hidden>
The memory_region_dispatch_{read|write} operand "unsigned size" is
being converted into a "MemOp op".
Convert interfaces by using no-op size_memop.
After all interfaces are converted, size_memop will be implemented
and the memory_region_dispatch_{read|write} operand "unsigned size"
will be converted into a "MemOp op".
As size_memop is a no-op, this patch does not change any behaviour.
Signed-off-by: Tony Nguyen <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/intc/armv7m_nvic.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
index 62ab8b7273..7220940133 100644
--- a/hw/intc/armv7m_nvic.c
+++ b/hw/intc/armv7m_nvic.c
@@ -21,6 +21,7 @@
#include "hw/qdev-properties.h"
#include "target/arm/cpu.h"
#include "exec/exec-all.h"
+#include "exec/memop.h"
#include "qemu/log.h"
#include "qemu/module.h"
#include "trace.h"
@@ -2348,7 +2349,8 @@ static MemTxResult nvic_sysreg_ns_write(void *opaque,
hwaddr addr,
if (attrs.secure) {
/* S accesses to the alias act like NS accesses to the real region */
attrs.secure = 0;
- return memory_region_dispatch_write(mr, addr, value, size, attrs);
+ return memory_region_dispatch_write(mr, addr, value, size_memop(size),
+ attrs);
} else {
/* NS attrs are RAZ/WI for privileged, and BusFault for user */
if (attrs.user) {
@@ -2367,7 +2369,8 @@ static MemTxResult nvic_sysreg_ns_read(void *opaque,
hwaddr addr,
if (attrs.secure) {
/* S accesses to the alias act like NS accesses to the real region */
attrs.secure = 0;
- return memory_region_dispatch_read(mr, addr, data, size, attrs);
+ return memory_region_dispatch_read(mr, addr, data, size_memop(size),
+ attrs);
} else {
/* NS attrs are RAZ/WI for privileged, and BusFault for user */
if (attrs.user) {
@@ -2393,7 +2396,8 @@ static MemTxResult nvic_systick_write(void *opaque,
hwaddr addr,
/* Direct the access to the correct systick */
mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->systick[attrs.secure]), 0);
- return memory_region_dispatch_write(mr, addr, value, size, attrs);
+ return memory_region_dispatch_write(mr, addr, value, size_memop(size),
+ attrs);
}
static MemTxResult nvic_systick_read(void *opaque, hwaddr addr,
@@ -2405,7 +2409,7 @@ static MemTxResult nvic_systick_read(void *opaque, hwaddr
addr,
/* Direct the access to the correct systick */
mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->systick[attrs.secure]), 0);
- return memory_region_dispatch_read(mr, addr, data, size, attrs);
+ return memory_region_dispatch_read(mr, addr, data, size_memop(size),
attrs);
}
static const MemoryRegionOps nvic_systick_ops = {
--
2.17.1
- [Qemu-devel] [PATCH 00/36] tcg patch queue, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 02/36] memory: Introduce size_memop, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 04/36] hw/s390x: Access MemoryRegion with MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 03/36] target/mips: Access MemoryRegion with MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 05/36] hw/intc/armv7m_nic: Access MemoryRegion with MemOp,
Richard Henderson <=
- [Qemu-devel] [PATCH 07/36] hw/vfio: Access MemoryRegion with MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 06/36] hw/virtio: Access MemoryRegion with MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 09/36] cputlb: Access MemoryRegion with MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 10/36] memory: Access MemoryRegion with MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 11/36] hw/s390x: Hard code size with MO_{8|16|32|64}, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 08/36] exec: Access MemoryRegion with MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 12/36] target/mips: Hard code size with MO_{8|16|32|64}, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 13/36] exec: Hard code size with MO_{8|16|32|64}, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 01/36] tcg: TCGMemOp is now accelerator independent MemOp, Richard Henderson, 2019/09/03
- [Qemu-devel] [PATCH 15/36] cputlb: Replace size and endian operands for MemOp, Richard Henderson, 2019/09/03