[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personali
|
From: |
Sergio Lopez |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1) |
|
Date: |
Tue, 03 Sep 2019 12:23:14 +0200 |
|
User-agent: |
mu4e 1.2.0; emacs 26.2 |
Stefan Hajnoczi <address@hidden> writes:
> On Thu, Aug 29, 2019 at 06:50:27PM +0200, Sergio Lopez wrote:
>> case VIRTIO_MMIO_QUEUE_PFN:
>> + if (!proxy->legacy) {
>> + qemu_log_mask(LOG_GUEST_ERROR,
>> + "%s: read from legacy register (0x%lx) in non-legacy
>> mode\n",
>> + __func__, offset);
>
> Please use HWADDR_PRIx since offset has type hwaddr. On ILP32 and LLP64
> hosts %lx is only 32-bit.
Ack.
Thanks!
Sergio.
> Otherwise:
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature