Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices

[Tomáš Golembiovský]

On Thu, 29 Aug 2019 11:13:53 -0500
Eric Blake <address@hidden> wrote:

> On 8/29/19 11:03 AM, Tomáš Golembiovský wrote:
> > Add command for reporting devices on Windows guest. The intent is not so
> > much to report the devices but more importantly the driver (and its
> > version) that is assigned to the device.
> > 
> > Signed-off-by: Tomáš Golembiovský <address@hidden>  
> 
> > +++ b/qga/qapi-schema.json
> > @@ -1242,3 +1242,35 @@
> >  ##
> >  { 'command': 'guest-get-osinfo',
> >    'returns': 'GuestOSInfo' }
> > +
> > +##
> > +# @GuestDeviceInfo:
> > +#
> > +# @vendor-id: vendor ID as hexadecimal string in uper case without 0x 
> > prefix
> > +# @device-id: device ID as hexadecimal string in uper case without 0x 
> > prefix  
> 
> s/uper/upper/ twice

duh

> 
> Should these be ints instead of strings (yes, it means they would be
> decimal over the wire, which is not the typical representation)?

Yes, I'm also indecisive in this point too. Although I sort of planned
to switch it to `int` in v2 anyway.

> 
> > +# @driver-name: name of the associated driver
> > +# @driver-date: driver release date in format MM/DD/YY  
> 
> Why US-centric?  Better would be something like ISO, YYYY-MM-DD

I admit ISO form would be more fool proof (and I would like it better
too), but this is to stay consistent with format used in Windows
drivers[1].

> 
> > +# @driver-version: driver version
> > +#
> > +# Since: 4.1.1  
> 
> 4.2.  We don't tend to add features on stable backport branches (as this
> missed 4.1.0, we're unlikely to add it for 4.1.1).

Ah, ok.

Thanks,

    Tomas

[1] 
https://docs.microsoft.com/en-us/windows-hardware/drivers/install/inf-driverver-directive

-- 
Tomáš Golembiovský <address@hidden>