Re: [Qemu-devel] [PATCH v6 1/3] target/ppc: Optimize emulation of vpkpx instruction

[BALATON Zoltan]

On Tue, 27 Aug 2019, Richard Henderson wrote:
> On 8/27/19 2:37 AM, Stefan Brankovic wrote:
> > +    for (i = 0; i < 4; i++) {
> > +        switch (i) {
> > +        case 0:
> > +            /*
> > +             * Get high doubleword of vA to perfrom 6-5-5 pack of pixels
> > +             * 1 and 2.
> > +             */
> > +            get_avr64(avr, VA, true);
> > +            tcg_gen_movi_i64(result, 0x0ULL);
> > +            break;
> > +        case 1:
> > +            /*
> > +             * Get low doubleword of vA to perfrom 6-5-5 pack of pixels
> > +             * 3 and 4.
> > +             */
> > +            get_avr64(avr, VA, false);
> > +            break;
> > +        case 2:
> > +            /*
> > +             * Get high doubleword of vB to perfrom 6-5-5 pack of pixels
> > +             * 5 and 6.
> > +             */
> > +            get_avr64(avr, VB, true);
> > +            tcg_gen_movi_i64(result, 0x0ULL);
> > +            break;
> > +        case 3:
> > +            /*
> > +             * Get low doubleword of vB to perfrom 6-5-5 pack of pixels

If this is replaced by Richard's suggested version it does not matter but 
there's a typo in above comments. Probably you've meant perfrom -> perform

Regards,
BALATON Zoltan