Re: [Qemu-devel] [PATCH v2] block: workaround for unaligned byte range in fallocate()

[Eric Blake]

On 8/27/19 9:04 AM, Andrey Shinkevich wrote:
> 
> 
> On 27/08/2019 16:55, Eric Blake wrote:
>> On 8/27/19 8:52 AM, Andrey Shinkevich wrote:
>>> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure'
>>> and use better error handling for file systems that do not support
>>> fallocate() for an unaligned byte range. Allow falling back to pwrite
>>> in case fallocate() returns EINVAL.
>>>
>>> Suggested-by: Kevin Wolf <address@hidden>
>>> Suggested-by: Eric Blake <address@hidden>
>>> Signed-off-by: Andrey Shinkevich <address@hidden>
>>> Reviewed-by: Eric Blake <address@hidden>
>>> ---
>>>   block/file-posix.c | 7 +++++++
>>>   block/io.c         | 2 +-
>>>   2 files changed, 8 insertions(+), 1 deletion(-)
>>
>> Queuing this in my NBD tree (as I performed testing on top of it when
>> working on NBD fast-zero).
>>
> Eric,
> I'm sorry about missing your message in the previous email thread - just 
> few minute difference. Please add
> Reviewed-by: Denis V. Lunev <address@hidden>
> because I used the stale commit ID from bash history and that line 
> didn't go to the v2 patch (((

No problem - crossed emails is nothing new. I'll add the R-b.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature