[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] nbd: Tolerate more errors to structured
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] nbd: Tolerate more errors to structured reply request |
Date: |
Tue, 27 Aug 2019 09:47:06 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Sat, Aug 24, 2019 at 12:28:13PM -0500, Eric Blake wrote:
> A server may have a reason to reject a request for structured replies,
> beyond just not recognizing them as a valid request; similarly, it may
> have a reason for rejecting a request for a meta context. It doesn't
> hurt us to continue talking to such a server; otherwise 'qemu-nbd
> --list' of such a server fails to display all available details about
> the export.
>
> Encountered when temporarily tweaking nbdkit to reply with
> NBD_REP_ERR_POLICY. Present since structured reply support was first
> added (commit d795299b reused starttls handling, but starttls is
> different in that we can't fall back to other behavior on any error).
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> nbd/client.c | 63 +++++++++++++++++++++++++-----------------------
> nbd/trace-events | 2 +-
> 2 files changed, 34 insertions(+), 31 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|