Re: [Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

[Richard Henderson]

On 8/23/19 5:03 AM, Peter Maydell wrote:
> On Mon, 19 Aug 2019 at 22:38, Richard Henderson
> <address@hidden> wrote:
> 
> In subject, typo: "Miscellaneous".
> 
>> This fixes an exiting bug with the T5 encoding of SUBS PC, LR, #IMM,
> 
> "existing"
> 
>> in that it may be executed from user mode as with any other encoding
>> of SUBS, not as ERET.
> 
> Should this paragraph be in the commit message for the previous
> patch? This change doesn't touch SUBS/ERET.
> 
> Otherwise
> Reviewed-by: Peter Maydell <address@hidden>

Indeed that text should not be here.

And also, as you might be able to tell from the text of the previous patch, it
isn't an existing bug.  It took me a while to see that, and that's why I think
that passing pre-v7m through the usual SUBS path is clearer.


r~