[Qemu-devel] [Bug 1840648] Re: qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161: logical fault ?

[Peter Maydell]

This isn't QEMU code -- it's just the source for third-party ROMs that
we ship with QEMU because we also ship the ROM binaries. Please report
it to the upstream project.


** Changed in: qemu
       Status: New => Invalid

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840648

Title:
  qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:
  logical fault ?

Status in QEMU:
  Invalid

Bug description:
  qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:71:
  warning: Logical disjunction always evaluates to true: EXPR != '\\' ||
  EXPR != '\0'. [incorrectLogicOperator]

  Source code is

         if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') ||
                                             (*(FileName + 2) != L'\0'))) {

  Maybe better code:

         if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') &&
                                             (*(FileName + 2) != L'\0'))) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840648/+subscriptions