[Qemu-devel] [Bug 1840646] Re: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

[Peter Maydell]

This isn't QEMU code -- it's just the source for third-party ROMs that
we ship with QEMU because we also ship the ROM binaries. Please report
it to the upstream project.


** Changed in: qemu
       Status: New => Invalid

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840646

Title:
  qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

Status in QEMU:
  Invalid

Bug description:
  qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
  conjunction always evaluates to false: alen <= 0 && alen >=
  sizeof(args) - 1. [incorrectLogicOperator]

  Source code is

     if (alen <= 0 && alen >= sizeof(args) - 1) {

  Maybe better code:

     if (alen <= 0 || alen >= sizeof(args) - 1) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840646/+subscriptions