[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit les
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/ |
|
Date: |
Wed, 7 Aug 2019 10:56:43 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/7/19 8:29 AM, Philippe Mathieu-Daudé wrote:
> On 8/6/19 11:40 PM, John Snow wrote:
>> On 8/6/19 11:14 AM, Markus Armbruster wrote:
>>> According to hw/ide/internal's file comment, only files in hw/ide/ are
>>> supposed to include it. Drag reality slightly closer to supposition.
>>>
>>
>> The downside of having your internal include ripped away and stuck in
>> the includes/ folder.
>
> Not sure this is a 'downside', it looks more than proper design issue to
> me (often the case with very old subsystems).
>
For context, the "internal" header here used to actually be internal. It
was moved wholesale to the "public" includes directory, which makes it
easier for people to start stealing things from inside of it, which
causes trouble.
--js
- Re: [Qemu-devel] [PATCH v2 01/29] include: Make headers more self-contained, (continued)
[Qemu-devel] [PATCH v2 14/29] migration: Move the VMStateDescription typedef to typedefs.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 07/29] trace: Do not include qom/cpu.h into generated trace.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 17/29] Include qom/object.h slightly less, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 16/29] Include exec/memory.h slightly less, Markus Armbruster, 2019/08/06