[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 27/28] sysemu: Move the VMChangeStateEntry typed
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 27/28] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h |
|
Date: |
Fri, 2 Aug 2019 15:21:54 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 02/08/19 15:16, Markus Armbruster wrote:
> * VMChangeStateEntry and the three functions using it, obviously, along
> with VMChangeStateHandler.
>
> * vm_state_notify(), because it belongs to the above.
>
> * The runstate_FOO() functions, because they're named like the new
> header?
>
> * vm_stop(), vm_stop_force_state(), vmstop_requested(),
> vmstop_requested, because they use RunState?
>
> * The remaining vm_FOO(), because they're closely related to vm_stop()?
>
> * Everything else from qemu_exit_preconfig_request() to
> qemu_remove_exit_notifier(), along with WakeupReason?
Yes, that could be an idea, but not qemu_add/remove_exit_notifier.
Paolo