Re: [Qemu-devel] [PATCH v4 23/54] tcg: let plugins instrument virtual memory accesses

[Richard Henderson]

On 7/31/19 9:06 AM, Alex Bennée wrote:
> From: "Emilio G. Cota" <address@hidden>
> 
> To capture all memory accesses we need hook into all the various
> helper functions that are involved in memory operations as well as the
> injected inline helper calls. A later commit will allow us to resolve
> the actual guest HW addresses by replaying the lookup.
> 
> Signed-off-by: Emilio G. Cota <address@hidden>
> [AJB: drop haddr handling, just deal in vaddr]
> Signed-off-by: Alex Bennée <address@hidden>
> 
> ---
> v3
>   - fixes for cpu_neg()
> v4
>   - rebase fixups, moved cpu_neg() fixes down the stack
>   - drop haddr support - will be restored with later helper
>   - reword commit
> ---
>  accel/tcg/atomic_common.inc.c             |  4 +++
>  accel/tcg/atomic_template.h               |  1 +
>  accel/tcg/cpu-exec.c                      |  3 ++
>  accel/tcg/cputlb.c                        | 14 ++++----
>  include/exec/cpu-defs.h                   |  1 +
>  include/exec/cpu_ldst_template.h          | 28 +++++++++-------
>  include/exec/cpu_ldst_useronly_template.h | 29 ++++++++--------
>  tcg/tcg-op.c                              | 40 ++++++++++++++++++-----
>  tcg/tcg.h                                 |  1 +
>  9 files changed, 79 insertions(+), 42 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~