Re: [Qemu-devel] [PATCH 3/3] iotests/118: Add -blockdev based tests

[Max Reitz]

On 31.07.19 22:42, Kevin Wolf wrote:
> The code path for -device drive=<node-name> or without a drive=...
> option for empty drives, which is supposed to be used with -blockdev
> differs enough from the -drive based path with a user-owned
> BlockBackend, so we want to test both paths at least for the basic tests
> implemented by TestInitiallyFilled and TestInitiallyEmpty.
> 
> This would have caught the bug recently fixed for inserting read-only
> nodes into a scsi-cd created without a drive=... option.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/118     | 43 ++++++++++++++++++++++++++------------
>  tests/qemu-iotests/118.out |  4 ++--
>  2 files changed, 32 insertions(+), 15 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature