|
| From: | Christian Borntraeger |
| Subject: | Re: [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call |
| Date: | Tue, 30 Jul 2019 19:09:56 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 30.07.19 18:46, Peter Maydell wrote: > On Tue, 30 Jul 2019 at 17:05, Andrey Shinkevich > <address@hidden> wrote: >> >> Not the whole structure is initialized before passing it to the KVM. >> Reduce the number of Valgrind reports. >> >> Signed-off-by: Andrey Shinkevich <address@hidden> > > Does it even make sense to try to valgrind a KVM-enabled run > of QEMU? As soon as we run the guest it will make modifications > to memory which Valgrind can't track; and I don't think > Valgrind supports the KVM_RUN ioctl anyway... As long as we do not care about the guest memory, it does make sense and it does find bugs. See also https://www.linux-kvm.org/page/KVM_Forum_2014 https://www.linux-kvm.org/images/d/d2/03x07-Valgrind.pdf Unfortunately I wasnt able to follow up on those.
| [Prev in Thread] | Current Thread | [Next in Thread] |