[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 04/15] block/io_uring: implements interfaces
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v7 04/15] block/io_uring: implements interfaces for io_uring |
Date: |
Tue, 30 Jul 2019 08:28:29 +0100 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
On Mon, Jul 29, 2019 at 08:46:40PM +0530, Aarushi Mehta wrote:
> +/**
> + * luring_process_completions:
> + * @s: AIO state
> + *
> + * Fetches completed I/O requests, consumes cqes and invokes their callbacks
> + * The function is somewhat tricky because it supports nested event loops,
> for
> + * example when a request callback invokes aio_poll(). In order to do this,
> + * indices are kept in LuringState. Function schedules BH completion so it
The sentence about indices is outdated and can be removed.
Otherwise:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v7 00/15] Add support for io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 01/15] configure: permit use of io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 02/15] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 03/15] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 04/15] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/07/29
- Re: [Qemu-devel] [PATCH v7 04/15] block/io_uring: implements interfaces for io_uring,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v7 05/15] stubs: add stubs for io_uring interface, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 06/15] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 07/15] blockdev: adds bdrv_parse_aio to use io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 08/15] block/file-posix.c: extend to use io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 09/15] block: add trace events for io_uring, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 10/15] block/io_uring: adds userspace completion polling, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 11/15] qemu-io: adds option to use aio engine, Aarushi Mehta, 2019/07/29
- [Qemu-devel] [PATCH v7 12/15] qemu-img: adds option to use aio engine for benchmarking, Aarushi Mehta, 2019/07/29