[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 22/28] Include hw/boards.h a bit less
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 22/28] Include hw/boards.h a bit less |
Date: |
Mon, 29 Jul 2019 17:07:57 -0300 |
On Fri, Jul 26, 2019 at 02:05:36PM +0200, Markus Armbruster wrote:
> hw/boards.h pulls in almost 60 headers. The less we include it into
> headers, the better. As a first step, drop superfluous inclusions,
> and downgrade some more to what's actually needed. Gets rid of just
> one inclusion into a header.
>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
[...]
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index c58a8e594e..2c9c93983a 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -15,7 +15,6 @@
> #include "qapi/qmp/qerror.h"
> #include "sysemu/replay.h"
> #include "qemu/units.h"
> -#include "hw/boards.h"
> #include "qapi/error.h"
> #include "qapi/qapi-visit-common.h"
> #include "qapi/visitor.h"
This doesn't look right. hw/core/machine.c contains the
implementation of most functions declared at hw/boards.h, and
surely requires struct MachineClass and struct MachineState to be
defined.
--
Eduardo
- [Qemu-devel] [PATCH 15/28] Include migration/vmstate.h less, (continued)
- [Qemu-devel] [PATCH 15/28] Include migration/vmstate.h less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 19/28] Include qemu/queue.h slightly less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 01/28] include: Make headers more self-contained, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 21/28] Include hw/qdev-properties.h less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 22/28] Include hw/boards.h a bit less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 18/28] Include hw/hw.h exactly where needed, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 12/28] Include hw/irq.h a lot less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 28/28] Include sysemu/sysemu.h a lot less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 26/28] Clean up inclusion of sysemu/sysemu.h, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 20/28] Include qemu/main-loop.h less, Markus Armbruster, 2019/07/26