Re: [Qemu-devel] [for 4.1 PATCH] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs"

[Cornelia Huck]

On Mon, 29 Jul 2019 16:59:09 +0100
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:

> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> This reverts commit f2784eed306449c3d04a71a05ed6463b8289aedf
> since that accidentally removes the PCIe capabilities from virtio
> devices because virtio_pci_dc_realize is called before the new 'mode'
> flag is set.

Yes, this is probably too hairy to fix for 4.1; but the change might be
worthwhile to revisit for 4.2.

> I keep the expanded hw_compat entry because we've lost the ability to
> do 'optional'.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  hw/display/virtio-gpu-pci.c   |  4 +---
>  hw/display/virtio-vga.c       |  4 +---
>  hw/virtio/virtio-crypto-pci.c |  4 +---
>  hw/virtio/virtio-input-pci.c  |  4 +---
>  hw/virtio/virtio-pci.c        | 26 ++++++++++----------------
>  hw/virtio/virtio-pci.h        | 31 ++++++-------------------------
>  6 files changed, 20 insertions(+), 53 deletions(-)

Reviewed-by: Cornelia Huck <address@hidden>